On 10/31/18 11:05 AM, Philippe Mathieu-Daudé wrote:
On 31/10/18 15:57, Eric Blake wrote:
On 10/31/18 12:39 AM, Fam Zheng wrote:
...
- fprintf(stderr, "%s: stat failed: %s\n",
- fname, strerror(errno));
+ error_setg(errp, "%s: stat failed: %s", fname,
strerror(errno));
return -errno;
error_setg_errno() is nicer here. In fact, should we have a Coverity
script that looks for error_setg(... strerror())?
Coverity -> Coccinelle?
Yes. (Is it okay if I begin my defense with: They both start with "Co"?)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
