Calling error_report() or similar in a function that takes an Error ** argument is suspicious. Fix a number of instances that are actually wrong. Clean up a few more that are merely fragile / bad examples.
v3: * PATCH 27: Drop useless error message prefix [Gerd] * PATCH 36-38: New v2: * PATCH 01: New * PATCH 02: Commit hash corrected in commit message [Eric] * PATCH 13: Error messages tidied up [Marc-André] * PATCH 15: Commit message tidied up [Eduardo H.] * PATCH 16: Unwanted string split fixed [Marc-André, Eduardo O.] * PATCH 20: Commit message corrected [Marc-André] * PATCH 25-26: New * PATCH 27: Rebased, commit message corrected * PATCH 30: Commit message tidied up [Eric] * PATCH 32: Less confusing commit message, help fixed [Max] * PATCH 33: New Fei Li (1): ui: Convert vnc_display_init(), init_keyboard_layout() to Error Markus Armbruster (37): error: Fix use of error_prepend() with &error_fatal, &error_abort Use error_fatal to simplify obvious fatal errors (again) block: Use warn_report() & friends to report warnings cpus hw target: Use warn_report() & friends to report warnings vfio: Use warn_report() & friends to report warnings vfio: Clean up error reporting after previous commit char: Use error_printf() to print help and such 9pfs: Fix CLI parsing crash on error pc: Fix machine property nvdimm-persistence error handling ioapic: Fix error handling in realize() smbios: Clean up error handling in smbios_add() migration: Fix !replay_can_snapshot() error handling l2tpv3: Improve -netdev/netdev_add/-net/... error reporting net/socket: Fix invalid socket type error handling numa: Fix QMP command set-numa-node error handling xen/pt: Fix incomplete conversion to realize() seccomp: Clean up error reporting in parse_sandbox() vl: Clean up error reporting in parse_add_fd() qom: Clean up error reporting in user_creatable_add_opts_foreach() vl: Clean up error reporting in chardev_init_func() vl: Clean up error reporting in machine_set_property() vl: Clean up error reporting in mon_init_func() vl: Clean up error reporting in parse_fw_cfg() vl: Clean up error reporting in device_init_func() ui/keymaps: Fix handling of erroneous include files vnc: Clean up error reporting in vnc_init_func() numa: Clean up error reporting in parse_numa() tpm: Clean up error reporting in tpm_init_tpmdev() spice: Clean up error reporting in add_channel() fsdev: Clean up error reporting in qemu_fsdev_add() vl: Assert drive_new() does not fail in default_drive() blockdev: Convert drive_new() to Error vl: Fix exit status for -drive format=help vl: Simplify call of parse_name() block: Clean up bdrv_img_create()'s error reporting raw: Convert a warning to warn_report() vpc: Fail open on bad header checksum block.c | 9 +- block/bochs.c | 8 +- block/cloop.c | 8 +- block/dmg.c | 8 +- block/iscsi.c | 2 +- block/qcow2.c | 4 +- block/qed.c | 4 +- block/raw-format.c | 17 +-- block/rbd.c | 12 +- block/sheepdog.c | 2 +- block/vpc.c | 8 +- block/vvfat.c | 8 +- blockdev.c | 27 ++--- chardev/char-pty.c | 2 +- chardev/char.c | 2 +- cpus.c | 8 +- device-hotplug.c | 5 +- fsdev/qemu-fsdev-dummy.c | 2 +- fsdev/qemu-fsdev.c | 12 +- fsdev/qemu-fsdev.h | 2 +- hw/9pfs/9p-handle.c | 6 +- hw/9pfs/9p-local.c | 4 +- hw/9pfs/xen-9p-backend.c | 7 +- hw/display/cg3.c | 2 +- hw/display/tcx.c | 2 +- hw/i386/pc.c | 5 +- hw/intc/ioapic.c | 8 +- hw/intc/xics.c | 15 ++- hw/intc/xics_kvm.c | 7 +- hw/misc/ivshmem.c | 4 +- hw/net/virtio-net.c | 8 +- hw/ppc/pnv_core.c | 4 +- hw/ppc/spapr_pci.c | 7 +- hw/smbios/smbios.c | 90 ++++++++++----- hw/timer/aspeed_timer.c | 3 +- hw/usb/bus.c | 5 +- hw/vfio/pci-quirks.c | 4 +- hw/vfio/pci.c | 25 ++-- hw/vfio/platform.c | 6 +- hw/virtio/virtio-pci.c | 4 +- hw/xen/xen_pt.c | 2 +- include/hw/vfio/vfio-common.h | 3 +- include/qapi/error.h | 14 +++ include/sysemu/blockdev.h | 3 +- include/sysemu/numa.h | 1 - include/sysemu/tpm.h | 2 +- include/ui/console.h | 2 +- migration/migration.c | 12 +- migration/savevm.c | 8 +- net/l2tpv3.c | 25 ++-- net/socket.c | 4 +- numa.c | 21 ++-- qemu-io.c | 8 +- qemu-nbd.c | 14 +-- qemu-seccomp.c | 18 +-- qom/object_interfaces.c | 4 +- scripts/coccinelle/use-error_fatal.cocci | 20 ++++ stubs/tpm.c | 3 +- target/i386/cpu.c | 17 +-- target/ppc/translate_init.inc.c | 4 +- tpm.c | 22 ++-- ui/curses.c | 6 +- ui/keymaps.c | 40 ++++--- ui/keymaps.h | 2 +- ui/sdl.c | 6 +- ui/spice-core.c | 13 ++- ui/vnc.c | 19 ++-- util/error.c | 13 +++ vl.c | 139 +++++++++-------------- 69 files changed, 435 insertions(+), 376 deletions(-) create mode 100644 scripts/coccinelle/use-error_fatal.cocci -- 2.17.1
