On 10/12/18 10:30 AM, Bastian Koppelmann wrote:
> +static bool trans_andi(DisasContext *ctx, arg_andi *a, uint32_t insn)
> +{
> + gen_arith_imm(ctx, OPC_RISC_ANDI, a->rd, a->rs1, a->imm);
> + return true;
> +}
> +static bool trans_slli(DisasContext *ctx, arg_slli *a, uint32_t insn)
> +{
> + if (a->rd != 0) {
> + TCGv t = tcg_temp_new();
> + gen_get_gpr(t, a->rs1);
> +
> + if (a->shamt >= TARGET_LONG_BITS) {
> + gen_exception_illegal(ctx);
> + return true;
> + }
> + tcg_gen_shli_tl(t, t, a->shamt);
> +
> + gen_set_gpr(a->rd, t);
> + tcg_temp_free(t);
> + } /* NOP otherwise */
> + return true;
> +}
Spacing. Any reason why trans_slli (and the other shifts) aren't using
gen_arith_imm as well?
> +static bool trans_addw(DisasContext *ctx, arg_addw *a, uint32_t insn)
> +{
> +#if !defined(TARGET_RISCV64)
> + gen_exception_illegal(ctx);
> + return true;
> +#endif
> + gen_arith(ctx, OPC_RISC_ADDW, a->rd, a->rs1, a->rs2);
> + return true;
> +}
return false, like you did for trans_ld?
r~
