Hi This series are split in three parts: - All VMState changes/fixes are together at the beggining (patches 1-9) - Devices whose port is trivial: (patches 10-40) - Devices whose port needs some change in types, or introduce a new struct to include all the device state: rest of patches.
There are three warnings and one error for checpatch. The Last one is a bug on checpatch, as there is no need to put spaces there (and putting params makes the preprecessor choke). And the other three, we can use worse arguments names or having longer than 80 chars macro definitions. I think that all are ok. #31: FILE: hw/hw.h:442: +#define VMSTATE_VARRAY_UINT32(_field, _state, _field_num, _version, _info, _type) {\ WARNING: line over 80 characters #23: FILE: hw/hw.h:512: +#define VMSTATE_STRUCT_VARRAY_INT32(_field, _state, _field_num, _version, _vmsd, _type) { \ #22: FILE: hw/hw.h:522: +#define VMSTATE_STRUCT_VARRAY_UINT32(_field, _state, _field_num, _version, _vmsd, _type) { \ #41: FILE: hw/hw.h:755: + VMSTATE_POINTER_TEST(_f, _s, _test, vmstate_info_timer, QEMUTimer *) ^ None of the patches should be difficult to review/accept. Please review. Anthony, apply the VMState ones the early possible, as it makes easier to work on other devices. Later, Juan. Juan Quintela (58): vmstate: add VMSTATE_UINT32_EQUAL vmstate: Fix varrays with uint8 indexes vmstate: add UINT32 VARRAYS vmstate: add VMSTATE_STRUCT_VARRAY_INT32 vmstate: add VMSTATE_INT64_ARRAY vmstate: add VMSTATE_STRUCT_VARRAY_UINT32 vmstate: Add a way to send a partial array vmstate: be able to store/save a pci device from a pointer vmstate: move timers to use test instead of version vmstate: port adb_kbd vmstate: port adb_mouse vmstate: port ads7846 vmstate: port m48t59 vmstate: port mipsnet vmstate: port arm sp804 vmstate: port arm_timer vmstate: port sysborg_timer vmstate: port pmtimer vmstate: port syborg_rtc vmstate: port pxa2xx_pic vmstate: port pxa2xx_keypad vmstate: port pl011 vmstate: port armv7m nvic vmstate: port stellaris i2c vmstate: port stellaris ssi bus vmstate: port stellaris sys vmstate: port pl022 ssp vmstate: port heathrow_pic vmstate: port cuda vmstate: port stellaris gptm vmstate: port pxa2xx_i2s vmstate: port pxa2xx_cm vmstate: port pxa2xx_mm vmstate: port pxa2xx_pm vmstate: port pxa2xx_rtc vmstate: port ppce500_pci vmstate: port ppc4xx_pci vmstate: port syborg_pointer vmstate: port stellaris_adc vmstate: port syborg_serial vmstate: port syborg_keyboard vmstate: port stellaris gamepad vmstate: stellaris use unused for placeholder entries pxa2xx_dma: make req array static vmstate: port pxa2xx_dma pxa2xx_lcd: name anonymous struct pxa2xx_lcd: up field is used as a bool and migrated as an uint8_t vmstate: port pxa2xx_lcdc max111x: input field is only used as uint8_t vmstate: port max111x nand: pin values are uint8_t vmstate: port nand mac_nvram: size is a size, no need to be a target dependent type vmstate: port mac_nvram piix4: create PIIX4State vmstate: port piix4 mac_dbdma: create DBDMAState instead of passing one array around vmstate: port mac_dbdma hw/adb.c | 83 +++++--------- hw/ads7846.c | 41 +++---- hw/arm_timer.c | 66 ++++------- hw/armv7m_nvic.c | 39 ++---- hw/cuda.c | 116 +++++++----------- hw/flash.h | 4 +- hw/heathrow_pic.c | 62 ++++------ hw/hw.h | 94 +++++++++++++-- hw/m48t59.c | 36 ++---- hw/mac_dbdma.c | 83 +++++++------ hw/mac_nvram.c | 32 ++--- hw/max111x.c | 51 +++----- hw/mipsnet.c | 53 +++------ hw/nand.c | 79 +++++++------ hw/piix4.c | 44 ++++---- hw/pl011.c | 76 ++++-------- hw/pl022.c | 84 ++++++-------- hw/ppc4xx_pci.c | 80 ++++++------- hw/ppce500_pci.c | 87 ++++++-------- hw/ptimer.c | 59 +++------- hw/pxa2xx.c | 243 +++++++++++++++----------------------- hw/pxa2xx_dma.c | 97 ++++++--------- hw/pxa2xx_keypad.c | 53 +++------ hw/pxa2xx_lcd.c | 138 +++++++++------------- hw/pxa2xx_pic.c | 52 +++----- hw/stellaris.c | 323 +++++++++++++++++--------------------------------- hw/stellaris_input.c | 50 ++++---- hw/syborg_keyboard.c | 57 +++------ hw/syborg_pointer.c | 73 +++++------- hw/syborg_rtc.c | 34 ++---- hw/syborg_serial.c | 60 +++------- hw/syborg_timer.c | 46 +++----- qemu-timer.h | 2 - savevm.c | 25 ++++ 34 files changed, 1048 insertions(+), 1474 deletions(-) -- 1.7.4