After noticing Fredrik patch [1] clashes with an ongoing work, I shared my concerns after the current limitations of CPUMIPSState::insn_flags, having 1 bit left to store more 'Chip specific instructions'.
Since v2: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg04064.html - rebased on upstream/master (previous was based on Fredrik's R5900) Since v1: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00933.html - update "int insn_flags;" in target/mips/translate.c::DisasContext - cleaned the 'insn_flags' namespace per Aleksandar suggestion - drop cpu defs used once - add my email in MAINTAINERS:MIPS to help me catch patches to review Regards, Phil. [1] http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg01978.html [2] http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg00901.html Philippe Mathieu-Daudé (4): target/mips: Increase the 'supported instructions' flags holder size target/mips: Remove definitions that are only used once target/mips: Clean the 'insn_flags' namespace MAINTAINERS: Voluntary to review hobbyist MIPS contributions target/mips/cpu.h | 2 +- target/mips/internal.h | 2 +- target/mips/mips-defs.h | 89 ++++++++++++++++++-------------- target/mips/translate.c | 6 +-- target/mips/translate_init.inc.c | 6 +-- MAINTAINERS | 2 + 6 files changed, 61 insertions(+), 46 deletions(-) -- 2.19.0
