On 31 August 2018 at 16:42, Andrew Jones <drjo...@redhat.com> wrote: > On Fri, Aug 31, 2018 at 03:20:45PM +0800, Hongbo Zhang wrote: >> If no DT in SBSA machine, then the code had much more difference with >> virt, so there is possibility to make it a simple separate file; >> If keep same DT as virt, then there are more overlap with virt codes, >> so I am not sure how the patch should like finally, I still prefer >> separate file to keep virt untouched, but not sure if others would >> suggest to extract common codes to a third file, it is up to the >> maintainer and reviewers. >> > > It sounds like you don't need many DT nodes, so a new file for > sbsa-ref, where you build whatever you want it to look like and > add the few DT nodes to inform firmware of a few parameters, > should be completely independent of mach-virt. I.e. I don't think > it even makes sense to refactor those few nodes in order to > share a tiny bit of DT node generation code. > Yes, this is what I intended to do as I mentioned.
> Thanks, > drew
