When inspecting the generated qapi-introspect.c (for debugging, or to see what QAPI changes are user visible vs. internal only), the fact that we've intentionally masked names from the QMP client makes it harder to tie back generated code back to the original QAPI .json files. We have a -u switch to qapi-gen for temporarily bypassing the name masking, but that's a rather heavy-handed tactic just for some temporary debugging. Better is to just make the generated file include strategic comments.
v1 was sent back in June, but was stalled due to 3.0 hard freeze. Now that 3.1 is open, it's time to revisit this. Since then: - drop the original patch 2 (deleting --unmask proved controversial) [Markus] - rebase patch on top of Marc-Andre's conditional work [Markus] - update documentation to match code change [Eric] - split out a preliminary cleanup patch [pep8] Eric Blake (2): qapi: Minor introspect.py cleanups qapi: Add comments to aid debugging generated introspection docs/devel/qapi-code-gen.txt | 1 + scripts/qapi/introspect.py | 34 ++++++++++++++++++++++++---------- 2 files changed, 25 insertions(+), 10 deletions(-) -- 2.17.1
