On 2018-08-22 23:45, John Snow wrote: > > > On 08/22/2018 07:52 AM, Max Reitz wrote: >> On 2018-08-22 13:43, Max Reitz wrote: >> >> [...] >> >>> I'd like .main_loop_settle(). Or .main_loop_post_run(). I think it's >>> OK to have names that aren't as cool and tense as possible, when in >>> return they actually tell you what they're doing. (Sure, >>> .main_loop_post_run() sounds really stupid, but it tells you exactly >>> when the function is called and what it's for.) >> >> Looking at the next patch, I realized that .main_loop_complete() or >> .complete_in_main_loop() would work just as well. (No, I don't see any >> confusion with whether you need to call job_completed(), especially >> since after this series you can probably make that function static to >> job.c.) >> >> Max >> > > I'm sorry to announce that after the part two of this series, the > callback will be erased completely, so the name is maybe less... important.
That's what I get for not reading the cover letter. Max
signature.asc
Description: OpenPGP digital signature
