On 2018-08-16 20:58, Laurent Vivier wrote: > Le 11/08/2018 à 17:26, Richard Henderson a écrit : > > On 08/11/2018 01:23 AM, Laurent Vivier wrote: > >> This fixes java in a linux-user chroot: > >> $ java --version > >> qemu-sh4: .../accel/tcg/cpu-exec.c:634: cpu_loop_exec_tb: Assertion > >> `use_icount' failed. > >> qemu: uncaught target signal 6 (Aborted) - core dumped > >> Aborted (core dumped) > >> > >> In gen_conditional_jump() in the GUSA_EXCLUSIVE part, we must reset > >> base.is_jmp to DISAS_NEXT after the gen_goto_tb() as it is done in > >> gen_delayed_conditional_jump() after the gen_jump(). > >> > >> Bug: https://bugs.launchpad.net/qemu/+bug/1768246 > >> Fixes: 4834871bc95b67343248100e2a75ae0d287bc08b > >> ("target/sh4: Convert to DisasJumpType") > >> Reported-by: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de> > >> Signed-off-by: Laurent Vivier <laur...@vivier.eu> > >> --- > >> > >> Notes: > >> v2: > >> don't revert the part of the original patch, > >> but fixes the state problem in gen_conditional_jump() > > > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
Reviewed-by: Aurelien Jarno <aurel...@aurel32.net> > Aurélien, > > do you agree if I push this patch through a linux-user pull request? Yes, that's fine with me. Thanks, Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net
