On 10/08/2018 16:06, Robert Hoo wrote: > +typedef enum FeatureWordType { > + CPUID_FEATURE_WORD, > + MSR_FEATURE_WORD, > +} FeatureWordType;
This enum probably should be defined with QAPI, so that it can be reused in the feature-words property: # @X86CPUFeatureWordType: # # Kinds of X86 CPU feature words # # @cpuid: A CPUID leaf # # @msr: An MSR ## { 'enum': 'X86CPUFeatureWordType', 'data': 'cpuid', 'msr' } The names will be X86_CPU_FEATURE_WORD_TYPE_CPUID and X86_CPU_FEATURE_WORD_TYPE_MSR. Thanks, Paolo