Paolo Bonzini <pbonz...@redhat.com> wrote: > On 08/08/2018 13:48, Juan Quintela wrote: >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> --- >> default-configs/alpha-softmmu.mak | 2 -- >> default-configs/arm-softmmu.mak | 2 -- >> default-configs/hppa-softmmu.mak | 3 --- >> default-configs/i386-softmmu.mak | 2 -- >> default-configs/mips-softmmu-common.mak | 2 -- >> default-configs/ppc-softmmu.mak | 1 - >> default-configs/ppcemb-softmmu.mak | 2 -- >> default-configs/sh4-softmmu.mak | 2 -- >> default-configs/sh4eb-softmmu.mak | 2 -- >> default-configs/sparc64-softmmu.mak | 2 -- >> default-configs/x86_64-softmmu.mak | 2 -- >> 11 files changed, 22 deletions(-) > > I don't think CONFIG_SERIAL_ISA should be in pci.mak though
agreed. >, and > CONFIG_SERIAL is a dependency of both CONFIG_SERIAL and > CONFIG_SERIAL_PCI. I guess you here mean CONFIG_SERIAL_ISA or CONFIG_SERIAL_PCI. That is not enough. CONFIG_SERIAL really means CONFIG_SERIAL_COMMON, and things like riscv* require it (i.e. basically all the weird(*) boards have a serial port) > Perhaps introduce a superio.mak with all the legacy > ISA devices? What are the surperio.mak or isa.mak. And once there, what are the isa devices? Weird things that came to my mind that can't be disabled: - mmmouse - serial-isa - fdc - vmport - vga-isa (this is another weird thing) - ipmi-isa? - what else? Later, Juan. (*): weird here means that they don't have PCI available.
