On 08/08/2018 01:48 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela <quint...@redhat.com> > --- > default-configs/alpha-softmmu.mak | 2 -- > default-configs/arm-softmmu.mak | 2 -- > default-configs/hppa-softmmu.mak | 3 --- > default-configs/i386-softmmu.mak | 2 -- > default-configs/mips-softmmu-common.mak | 2 -- > default-configs/ppc-softmmu.mak | 1 - > default-configs/ppcemb-softmmu.mak | 2 -- > default-configs/sh4-softmmu.mak | 2 -- > default-configs/sh4eb-softmmu.mak | 2 -- > default-configs/sparc64-softmmu.mak | 2 -- > default-configs/x86_64-softmmu.mak | 2 -- > 11 files changed, 22 deletions(-) > > diff --git a/default-configs/alpha-softmmu.mak > b/default-configs/alpha-softmmu.mak > index bbe361f01a..2d81a98441 100644 > --- a/default-configs/alpha-softmmu.mak > +++ b/default-configs/alpha-softmmu.mak > @@ -2,8 +2,6 @@ > > include pci.mak > include usb.mak > -CONFIG_SERIAL=y > -CONFIG_SERIAL_ISA=y > CONFIG_I82374=y > CONFIG_I8254=y > CONFIG_I8257=y > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak > index 834d45cfaf..4d33e9983d 100644 > --- a/default-configs/arm-softmmu.mak > +++ b/default-configs/arm-softmmu.mak > @@ -5,8 +5,6 @@ include usb.mak > CONFIG_VGA=y > CONFIG_NAND=y > CONFIG_ECC=y > -CONFIG_SERIAL=y > -CONFIG_SERIAL_ISA=y > CONFIG_PTIMER=y > CONFIG_SD=y > CONFIG_MAX7310=y > diff --git a/default-configs/hppa-softmmu.mak > b/default-configs/hppa-softmmu.mak > index 4badc0521e..f3712afc27 100644 > --- a/default-configs/hppa-softmmu.mak > +++ b/default-configs/hppa-softmmu.mak > @@ -1,8 +1,5 @@ > include pci.mak > include usb.mak > -CONFIG_SERIAL=y > -CONFIG_SERIAL_ISA=y > -CONFIG_ISA_BUS=y
You should maybe mention CONFIG_ISA_BUS in the patch description, too. Apart from that nit: Reviewed-by: Thomas Huth <th...@redhat.com>