On 08/08/2018 01:48 PM, Juan Quintela wrote: > Once there, untangle endianness-test and boot-serial-test. > > Signed-off-by: Juan Quintela <quint...@redhat.com> > > -- > > boot-serial-test don't depend on isa-testdev. Thanks Thomas.
So remove it from the patch description, too? > Signed-off-by: Juan Quintela <quint...@redhat.com> > --- > tests/Makefile.include | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 2016c353e3..4e5f47aac0 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -248,7 +248,7 @@ gcov-files-pci-y += hw/misc/ivshmem.c > check-qtest-pci-y += tests/megasas-test$(EXESUF) > gcov-files-pci-y += hw/scsi/megasas.c > > -check-qtest-i386-y = tests/endianness-test$(EXESUF) > +check-qtest-i386-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) > check-qtest-i386-y += tests/fdc-test$(EXESUF) > gcov-files-i386-y = hw/block/fdc.c > check-qtest-i386-y += tests/ide-test$(EXESUF) > @@ -321,15 +321,15 @@ check-qtest-m68k-y = tests/boot-serial-test$(EXESUF) > > check-qtest-microblaze-y = tests/boot-serial-test$(EXESUF) > > -check-qtest-mips-y = tests/endianness-test$(EXESUF) > - > -check-qtest-mips64-y = tests/endianness-test$(EXESUF) > - > -check-qtest-mips64el-y = tests/endianness-test$(EXESUF) > - > check-qtest-moxie-y = tests/boot-serial-test$(EXESUF) > > -check-qtest-ppc-y = tests/endianness-test$(EXESUF) > +check-qtest-mips-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) > + > +check-qtest-mips64-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) > + > +check-qtest-mips64el-$(CONFIG_ISA_TESTDEV) = tests/endianness-test$(EXESUF) I think it would be good to try to keep the alphabetical order of the entries, i.e. keep mips before moxie? Thomas
