As discovered recently, you can crash QEMU with a lot of devices
that do not get the reference counting of child objects right.
You just have to run 'device-list-properties' and call 'info qtree'
afterwards.
This patch series fixes these problems in the ARM code. When all
patches have been applied, I now do not get any more hangs or crashes
when I add a hmp("info qtree") to the device-introspect-test.
Please have a look at patch #1, #15 and #16, they still need reviews.
v3:
- Reworked object_initialize_child according to Paolos suggestions
(patch 1)
- Added prototype description in the 2nd patch (as suggested by Eduardo)
- Replaced the xlnx_dp "realize" patch with the one from Paolo
- Added a patch for the "stm32f205_soc" device (surprisingly this was
already the last one that caused trouble - I originally expected more)
v2:
- Updated the first patch according to the review feedback from v1
- Added more patches with additional fixes
Paolo Bonzini (1):
hw/display/xlnx_dp: Move problematic code from instance_init to
realize
Thomas Huth (16):
qom/object: Add a new function object_initialize_child()
hw/core/sysbus: Add a function for creating and attaching an object
hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported
machines
hw/arm/armv7: Fix crash when introspecting the "iotkit" device
hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv
device
hw/arm/msf2-soc: Fix introspection problem with the "msf2-soc" device
hw/cpu/a9mpcore: Fix introspection problems with the "a9mpcore_priv"
device
hw/arm/fsl-imx6: Fix introspection problems with the "fsl,imx6" device
hw/arm/fsl-imx7: Fix introspection problems with the "fsl,imx7" device
hw/arm/fsl-imx25: Fix introspection problem with the "fsl,imx25"
device
hw/arm/fsl-imx31: Fix introspection problem with the "fsl,imx31"
device
hw/cpu/arm11mpcore: Fix introspection problem with 'arm11mpcore_priv'
hw/*/realview: Fix introspection problem with 'realview_mpcore' &
'realview_gic'
hw/arm/allwinner-a10: Fix introspection problem with 'allwinner-a10'
hw/arm/stm32f205_soc: Fix introspection problem with 'stm32f205-soc'
device
hw/arm/xlnx-zynqmp: Fix crash when introspecting the "xlnx,zynqmp"
device
hw/arm/allwinner-a10.c | 19 +++++-----
hw/arm/armv7m.c | 7 ++--
hw/arm/bcm2836.c | 18 +++------
hw/arm/fsl-imx25.c | 30 +++++++--------
hw/arm/fsl-imx31.c | 26 ++++++-------
hw/arm/fsl-imx6.c | 56 ++++++++++------------------
hw/arm/fsl-imx7.c | 97 ++++++++++++++++--------------------------------
hw/arm/iotkit.c | 74 ++++++++++++++++--------------------
hw/arm/msf2-soc.c | 15 ++++----
hw/arm/stm32f205_soc.c | 28 ++++++--------
hw/arm/xlnx-zynqmp.c | 61 ++++++++++++++----------------
hw/core/sysbus.c | 8 ++++
hw/cpu/a15mpcore.c | 8 ++--
hw/cpu/a9mpcore.c | 18 ++++-----
hw/cpu/arm11mpcore.c | 14 +++----
hw/cpu/realview_mpcore.c | 8 ++--
hw/display/xlnx_dp.c | 8 +++-
hw/intc/armv7m_nvic.c | 5 +--
hw/intc/realview_gic.c | 7 +---
hw/misc/auxbus.c | 18 ++++++---
include/hw/misc/auxbus.h | 14 ++++++-
include/hw/sysbus.h | 17 +++++++++
include/qom/object.h | 45 +++++++++++++++++++++-
qom/object.c | 54 +++++++++++++++++++++++++++
24 files changed, 355 insertions(+), 300 deletions(-)
--
1.8.3.1
