* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 30 June 2018 at 17:28, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On 29 June 2018 at 18:43, Dr. David Alan Gilbert (git) > > <dgilb...@redhat.com> wrote: > >> From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > >> > >> PPC tcg seems to be failing migration tests quite regularly; > >> we believe this is TCG bugs in dirty bit updating; it's > >> not clear why PPC fails more but lets skip for the moment. > >> > >> $ ./tests/migration-test > >> /ppc64/migration/deprecated: OK > >> /ppc64/migration/bad_dest: SKIP > >> /ppc64/migration/postcopy/unix: SKIP > >> /ppc64/migration/precopy/unix: SKIP > > > > This patch seems to make the test fail in some setups: > > Specifically, it's the 'gtester' command in 'make check' > that makes the difference: > > e104462:xenial:ppc$ QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 > tests/migration-test > /ppc64/migration/deprecated: OK > /ppc64/migration/bad_dest: SKIP > /ppc64/migration/postcopy/unix: SKIP > /ppc64/migration/precopy/unix: SKIP > e104462:xenial:ppc$ QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 > gtester -k --verbose -m=quick tests/migration-test > TEST: tests/migration-test... (pid=23304) > /ppc64/migration/deprecated: OK > /ppc64/migration/bad_dest: FAIL > GTester: last random seed: R02Sa45f28859314d31ea4e89aeee4851d87 > /ppc64/migration/postcopy/unix: FAIL > GTester: last random seed: R02Sa45f28859314d31ea4e89aeee4851d87 > /ppc64/migration/precopy/unix: FAIL > GTester: last random seed: R02Sa45f28859314d31ea4e89aeee4851d87 > PASS: tests/migration-test > > This seems to be a bug in gtester: > https://bugzilla.gnome.org/show_bug.cgi?id=790934
Bah, and I liked that I was using a nice new gtk feature. > which I guess we need to work around -- the easy approach would be to just > call this a pass rather than a skip, I suppose. Yeh, I'll rework it. I'll include a printf saying we skipped it though just to remove any false feeling of warmth and reassurance of an OK. > I also note that in that bug report the glib folks say > "don't use gtester, it's not maintained", and recommend that > we switch to something else (a 'TAP harness', whatever that is)... https://testanything.org/ I think, but I don't know anything about it. Dave > > thanks > -- PMM -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
