On 21 June 2018 at 02:53, Richard Henderson <richard.hender...@linaro.org> wrote: > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/arm/helper-sve.h | 56 ++++++++++++++++++++++++++++ > target/arm/sve_helper.c | 69 +++++++++++++++++++++++++++++++++++ > target/arm/translate-sve.c | 75 ++++++++++++++++++++++++++++++++++++++ > target/arm/sve.decode | 14 +++++++ > 4 files changed, 214 insertions(+)
> + > +#define float16_two make_float16(0x4000) > +#define float32_two make_float32(0x40000000) > +#define float64_two make_float64(0x4000000000000000ULL) We seem to have these already in include/fpu/softfloat.h. > +DO_FP_IMM(FADD, fadds, half, one) > +DO_FP_IMM(FSUB, fsubs, half, one) > +DO_FP_IMM(FMUL, fmuls, half, two) > +DO_FP_IMM(FSUBR, fsubrs, half, one) > +DO_FP_IMM(FMAXNM, fmaxnms, zero, one) > +DO_FP_IMM(FMINNM, fminnms, zero, one) > +DO_FP_IMM(FMAX, fmaxs, zero, one) > +DO_FP_IMM(FMIN, fmins, zero, one) > + > +#undef DO_FP_IMM Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM