It eases code review, unit is explicit. Patch generated using:
$ git grep -n '[<>][<>]= ?[1-5]0' and modified manually. Suggested-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index d451f45dc5..7729ba390f 100644 --- a/vl.c +++ b/vl.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#include "qemu/units.h" #include "qapi/error.h" #include "qemu-version.h" #include "qemu/cutils.h" @@ -2790,7 +2791,7 @@ static void set_memory_options(uint64_t *ram_slots, ram_addr_t *maxram_size, if (g_ascii_isdigit(mem_str[strlen(mem_str) - 1])) { uint64_t overflow_check = sz; - sz <<= 20; + sz *= MiB; if ((sz >> 20) != overflow_check) { error_report("too large 'size' option value"); exit(EXIT_FAILURE); -- 2.18.0