We've got a separate option to configure the accelerator nowadays. Use it in the source and examples to demonstrate that this is the preferred way of setting this option now.
Signed-off-by: Thomas Huth <th...@redhat.com> --- qemu-doc.texi | 3 +-- qemu-options.hx | 2 +- scripts/qtest.py | 2 +- tests/bios-tables-test.c | 2 +- tests/boot-serial-test.c | 2 +- tests/libqtest.c | 2 +- tests/migration-test.c | 8 ++++---- tests/migration/guestperf/engine.py | 2 +- tests/pnv-xscom-test.c | 2 +- tests/prom-env-test.c | 2 +- tests/pxe-test.c | 2 +- tests/qemu-iotests/172 | 2 +- tests/qemu-iotests/check | 2 +- tests/vmgenid-test.c | 2 +- 14 files changed, 17 insertions(+), 18 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index cd05760..1c47e7c 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -2793,8 +2793,7 @@ which is the default. @subsection -no-kvm (since 1.3.0) -The ``-no-kvm'' argument is now a synonym for setting -``-machine accel=tcg''. +The ``-no-kvm'' argument is now a synonym for setting ``-accel tcg''. @subsection -vnc tls (since 2.5.0) diff --git a/qemu-options.hx b/qemu-options.hx index c0d3951..451f7a6 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3922,7 +3922,7 @@ STEXI Enable FIPS 140-2 compliance mode. ETEXI -HXCOMM Deprecated by -machine accel=tcg property +HXCOMM Deprecated by -accel tcg DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386) DEF("msg", HAS_ARG, QEMU_OPTION_msg, diff --git a/scripts/qtest.py b/scripts/qtest.py index df0daf2..8c074a6 100644 --- a/scripts/qtest.py +++ b/scripts/qtest.py @@ -89,7 +89,7 @@ class QEMUQtestMachine(qemu.QEMUMachine): def _base_args(self): args = super(QEMUQtestMachine, self)._base_args() args.extend(['-qtest', 'unix:path=' + self._qtest_path, - '-machine', 'accel=qtest']) + '-accel', 'qtest']) return args def _pre_launch(self): diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 4e24930..f41ec39 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -613,7 +613,7 @@ static void test_acpi_one(const char *params, test_data *data) char *args; /* Disable kernel irqchip to be able to override apic irq0. */ - args = g_strdup_printf("-machine %s,accel=%s,kernel-irqchip=off " + args = g_strdup_printf("-machine %s,kernel-irqchip=off -accel %s " "-net none -display none %s " "-drive id=hd0,if=none,file=%s,format=raw " "-device ide-hd,drive=hd0 ", diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c index 4d6815c..84a2aa9 100644 --- a/tests/boot-serial-test.c +++ b/tests/boot-serial-test.c @@ -175,7 +175,7 @@ static void test_machine(const void *data) * Make sure that this test uses tcg if available: It is used as a * fast-enough smoketest for that. */ - global_qtest = qtest_startf("%s %s -M %s,accel=tcg:kvm " + global_qtest = qtest_startf("%s %s -M %s -accel tcg:kvm " "-chardev file,id=serial0,path=%s " "-no-shutdown -serial chardev:serial0 %s", codeparam, code ? codetmp : "", diff --git a/tests/libqtest.c b/tests/libqtest.c index 098af6a..51481b0 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -209,7 +209,7 @@ QTestState *qtest_init_without_qmp_handshake(bool use_oob, "-qtest-log %s " "-chardev socket,path=%s,nowait,id=char0 " "-mon chardev=char0,mode=control%s " - "-machine accel=qtest " + "-accel qtest " "-display none " "%s", qemu_binary, socket_path, getenv("QTEST_LOG") ? "/dev/fd/2" : "/dev/null", diff --git a/tests/migration-test.c b/tests/migration-test.c index 3a85446..2b96ff0 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -372,12 +372,12 @@ static void test_migrate_start(QTestState **from, QTestState **to, if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) { init_bootfile_x86(bootpath); - cmd_src = g_strdup_printf("-machine accel=%s -m 150M" + cmd_src = g_strdup_printf("-accel %s -m 150M" " -name source,debug-threads=on" " -serial file:%s/src_serial" " -drive file=%s,format=raw", accel, tmpfs, bootpath); - cmd_dst = g_strdup_printf("-machine accel=%s -m 150M" + cmd_dst = g_strdup_printf("-accel %s -m 150M" " -name target,debug-threads=on" " -serial file:%s/dest_serial" " -drive file=%s,format=raw" @@ -389,7 +389,7 @@ static void test_migrate_start(QTestState **from, QTestState **to, if (access("/sys/module/kvm_hv", F_OK)) { accel = "tcg"; } - cmd_src = g_strdup_printf("-machine accel=%s -m 256M" + cmd_src = g_strdup_printf("-accel %s -m 256M" " -name source,debug-threads=on" " -serial file:%s/src_serial" " -prom-env '" @@ -397,7 +397,7 @@ static void test_migrate_start(QTestState **from, QTestState **to, "do i c@ 1 + i c! 1000 +loop .\" B\" 0 " "until'", accel, tmpfs, end_address, start_address); - cmd_dst = g_strdup_printf("-machine accel=%s -m 256M" + cmd_dst = g_strdup_printf("-accel %s -m 256M" " -name target,debug-threads=on" " -serial file:%s/dest_serial" " -incoming %s", diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py index 398e3f2..cf3d7c8 100644 --- a/tests/migration/guestperf/engine.py +++ b/tests/migration/guestperf/engine.py @@ -286,7 +286,7 @@ class Engine(object): cmdline = "'" + cmdline + "'" argv = [ - "-machine", "accel=kvm", + "-accel", "kvm", "-cpu", "host", "-kernel", self._kernel, "-initrd", self._initrd, diff --git a/tests/pnv-xscom-test.c b/tests/pnv-xscom-test.c index efb7c83..4f6686c 100644 --- a/tests/pnv-xscom-test.c +++ b/tests/pnv-xscom-test.c @@ -79,7 +79,7 @@ static void test_cfam_id(const void *data) { const PnvChip *chip = data; - global_qtest = qtest_startf("-M powernv,accel=tcg -cpu %s", + global_qtest = qtest_startf("-M powernv -accel tcg -cpu %s", chip->cpu_model); test_xscom_cfam_id(chip); qtest_quit(global_qtest); diff --git a/tests/prom-env-test.c b/tests/prom-env-test.c index 8c867e6..e066269 100644 --- a/tests/prom-env-test.c +++ b/tests/prom-env-test.c @@ -49,7 +49,7 @@ static void test_machine(const void *machine) /* The pseries firmware boots much faster without the default devices */ extra_args = strcmp(machine, "pseries") == 0 ? "-nodefaults" : ""; - global_qtest = qtest_startf("-M %s,accel=tcg %s " + global_qtest = qtest_startf("-M %s -accel tcg %s " "-prom-env 'use-nvramrc?=true' " "-prom-env 'nvramrc=%x %x l!' ", (const char *)machine, extra_args, diff --git a/tests/pxe-test.c b/tests/pxe-test.c index 6e36796..a8c4daa 100644 --- a/tests/pxe-test.c +++ b/tests/pxe-test.c @@ -64,7 +64,7 @@ static void test_pxe_one(const testdef_t *test, bool ipv6) char *args; args = g_strdup_printf( - "-machine %s,accel=kvm:tcg -nodefaults -boot order=n " + "-machine %s -accel kvm:tcg -nodefaults -boot order=n " "-netdev user,id=" NETNAME ",tftp=./,bootfile=%s,ipv4=%s,ipv6=%s " "-device %s,bootindex=1,netdev=" NETNAME, test->machine, disk, ipv6 ? "off" : "on", ipv6 ? "on" : "off", diff --git a/tests/qemu-iotests/172 b/tests/qemu-iotests/172 index 02c5f79..93742a7 100755 --- a/tests/qemu-iotests/172 +++ b/tests/qemu-iotests/172 @@ -56,7 +56,7 @@ function do_run_qemu() done fi echo quit - ) | $QEMU -machine accel=qtest -nographic -monitor stdio -serial none "$@" + ) | $QEMU -accel qtest -nographic -monitor stdio -serial none "$@" echo } diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index aa94c6c..5ffbf5d 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests/check @@ -129,7 +129,7 @@ export CACHEMODE="writeback" export QEMU_IO_OPTIONS="" export QEMU_IO_OPTIONS_NO_FMT="" export CACHEMODE_IS_DEFAULT=true -export QEMU_OPTIONS="-nodefaults -machine accel=qtest" +export QEMU_OPTIONS="-nodefaults -accel qtest" export VALGRIND_QEMU= export IMGKEYSECRET= export IMGOPTSSYNTAX=false diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c index 8d915c6..4324034 100644 --- a/tests/vmgenid-test.c +++ b/tests/vmgenid-test.c @@ -131,7 +131,7 @@ static void read_guid_from_monitor(QemuUUID *guid) static char disk[] = "tests/vmgenid-test-disk-XXXXXX"; #define GUID_CMD(guid) \ - "-machine accel=kvm:tcg " \ + "-accel kvm:tcg " \ "-device vmgenid,id=testvgid,guid=%s " \ "-drive id=hd0,if=none,file=%s,format=raw " \ "-device ide-hd,drive=hd0 ", guid, disk -- 1.8.3.1