On 11 June 2018 at 16:55, Eric Blake <ebl...@redhat.com> wrote: > On 06/10/2018 08:14 PM, Philippe Mathieu-Daudé wrote: >> >> Hi, >> >> This series: >> >> - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.h" >> (this now triggers WARNING: 1 added file, does MAINTAINERS need >> updating?) >> - clean hw/ includes; >> - replace different constants used for byte size with their corresponding >> IEC binary prefix definitions. >> >> Since v3: >> - use IEC binary prefix definitions (Stefan Weil) >> - rebased >> - added R-b tags >> > >> hw/net/ne2000.h | 5 ++-- > > ... >> >> tests/test-qemu-opts.c | 7 +++--- >> scripts/checkpatch.pl | 1 + >> 135 files changed, 533 insertions(+), 431 deletions(-) >> create mode 100644 include/qemu/units.h >> > > At least monitor.c and vl.c are missing from this list; a more general grep > shows that the following are all potential candidates for this cleanup:
This patchset is already 40 patches long, though; if we like it then we should just go ahead with it and deal with the stragglers in a second series. thanks -- PMM
