On Sun, Jun 10, 2018 at 10:14:54PM -0300, Philippe Mathieu-Daudé wrote: > @@ -1392,11 +1393,11 @@ void pc_memory_init(PCMachineState *pcms, > } > > machine->device_memory->base = > - ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, 1ULL << 30); > + ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, GiB); >
For some reason, GiB got special treatment. Why not 1* GiB?