On Mon, Jun 04, 2018 at 11:32:44AM +0100, Daniel P. Berrangé wrote:
[...]
> Avoiding the double-run of main_loop is good, however, I think we should
> also not have put current_run_state in RUN_STATE_PRECONFIG in the first
> place if --preconfig wasn't set. I've sent a patch to fix that problem
> too, so if yours is also applied, it could be changed to just do:
>
> if (current_run_state == RNU_STATE_PRECONFIG) {
> main_loop();
> }
So, this patch is desirable even if we refactor the state machine
as suggested in the other threads, right?
I'm queueing it on machine-next right now.
--
Eduardo
