On Fri, May 25, 2018 at 01:32:40PM -0500, Eric Blake wrote: > On 05/25/2018 11:47 AM, Michael S. Tsirkin wrote: > > Right now, a local header can be included with either > > > > #include "foo.h" > > or > > #include "dir/foo.h" > > > > since the later doesn't tell you where the header is > > (in source or include directory), the former is preferable. > > > > I intend to look for ways to prevent the second way from working, but > > that will take time. For now, fix all instances for the later way I > > could find. > > > > In a couple of places I just dropped the include instead. > > > > Finally, arch_init huge list of includes is sorted, which will be > > helpful in future cleanups. > > > > This was part of the include path cleanup patchset > > (https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg00739.html). > > > > Changes from v1 > > drop patches not dealing with local headers > > stop saying include through root works by accident - > > it's not by accident, just not how we'd like code to look like > > You mostly did that, but I still think some of the commit messages can be > improved. See 15/20. > > > address comments by eric, philip, others > > At any rate, I think we are getting closer; and splitting this into a > less-controversial part compared to the rest of v1 makes it more likely that > this half can go in soon. Many of the patches are independent, but it's > still probably easier if this goes in through one tree (Paolo's misc tree, > perhaps?), once you've collected reviews.
I plan to just merge these through my tree. > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org
