On Fri, May 25, 2018 at 01:24:08PM -0500, Eric Blake wrote: > On 05/25/2018 11:48 AM, Michael S. Tsirkin wrote: > > When pulling in headers that are in the same directory as C file (as > > s/as C/as the C/ (here and in many other messages)
Will fix, thanks. > > opposed to one in include/), we should use its relative path, without a > > directory. Directory based path works more or less by accident. > > Missed trimming this out of your commit message. Will fix, thanks. > Or, if you want, on many of these commits, you could be more explicit about > intention: > > When pulling in headers that are in the same directory as the C file (as > opposed to one in include/), we prefer to use its relative path without a > directory, rather than relying on the global -I$(SRC_DIR) that may be > removed in a later patch. I'm no longer sure we'll be able to. > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org
