On 24/05/2018 09:53, Eduardo Otubo wrote: >>>>> >>>> Thanks! But I have not got response from Paolo. I have added him to >>>> CC list. >>>> >>> I'll just wait one more ACK and will send a pull request on the >>> seccomp queue. Thanks for the contribution. >>> >>> >> So... what I should do is wait? >> > Yes, even though I think we're safe to proceed without his explicit ack.
The patch is okay; however, as a follow-up, you could consider moving all the CONFIG_SECCOMP code to qemu-seccomp.c. This way, the only #ifdef remains the one around qemu_opts_foreach. Paolo