v3: Drop RFC.
Update iotests reference output.
Address Stefan's comments to v2:
- Added a TODO for qcow2 copy with refcnt within the same image.
- Include sys/syscall.h only on Linux.
- Provide a dummy implementation returning -ENOSYS to reduce #ifdefs.
- Use aio_ prefix for RawPosixAIOData fields.
- Iscsi: split patches for code refactoring and device designator query.
- Iscsi: improve parameter verification, types. don't use meaningless
offset calculation.
- Iscsi: set next pointer to NULL.
- Iscsi: don't free uninitialized pointers.
- Block backend: check request byte range.
- Add reviewed-by lines.
v2: - Add iscsi EXTENDED COPY.
- Design change: bdrv_co_copy_range_{from,to}. [Stefan]
- Retry upon EINTR. [Stefan]
- Drop the bounce buffer fallback. It is inefficient to attempt the
offloaded copy over and over again if the error is returned from the host
rather than checking our internal state. E.g. trying copy_file_range
between two filesystems results in EXDEV, in which case qemu-img.c should
switch back to the copy path for the remaining sectors.
This series introduces block layer API for copy offloading and makes use of it
in qemu-img convert.
For now we implemented the operation in local file protocol with
copy_file_range(2). Besides that it's possible to add similar to iscsi, nfs
and potentially more.
As far as its usage goes, in addition to qemu-img convert, we can emulate
offloading in scsi-disk (handle EXTENDED COPY command), and use the API in
block jobs too.
Fam Zheng (9):
block: Introduce API for copy offloading
raw: Implement copy offloading
qcow2: Implement copy offloading
file-posix: Implement bdrv_co_copy_range
iscsi: Query and save device designator when opening
iscsi: Create and use iscsi_co_wait_for_task
iscsi: Implement copy offloading
block-backend: Add blk_co_copy_range
qemu-img: Convert with copy offloading
block/block-backend.c | 18 +++
block/file-posix.c | 94 +++++++++++-
block/io.c | 91 +++++++++++
block/iscsi.c | 323 ++++++++++++++++++++++++++++++++++-----
block/qcow2.c | 228 +++++++++++++++++++++++----
block/raw-format.c | 20 +++
include/block/block.h | 4 +
include/block/block_int.h | 30 ++++
include/block/raw-aio.h | 10 +-
include/scsi/constants.h | 5 +
include/sysemu/block-backend.h | 4 +
qemu-img.c | 50 +++++-
tests/qemu-iotests/178.out.qcow2 | 8 +-
13 files changed, 807 insertions(+), 78 deletions(-)
--
2.14.3
