On 27.04.2018 18:30, Markus Armbruster wrote: > Thomas Huth <th...@redhat.com> writes: > >> On 27.04.2018 12:20, Peter Maydell wrote: >>> On 27 April 2018 at 07:06, Thomas Huth <th...@redhat.com> wrote: [...] >>>> Shall we change qom-test to also only test with the "none" machine in >>>> the normal "make check" mode and only do the full test with all machines >>>> in "make check SPEED=slow" ? >>> >>> We definitely want something that tries to instantiate every >>> machine, because that does catch bugs. >> >> Yes, after having a closer look at this one, I also think that we should >> *not* change it to run with "none" by default only. The 'qom-list' >> command results in quite a different output depending on which machine >> you run it on. > > Only running "none" is too naive.
For the targets that have "versioned" machine types, I think we could skip all the older machine versions, so that we only test with pc-i440fx-2.12 but not with pc-i440fx-2.11 and older anymore. That would need some more or less clever algorithm to detect the latest version, though. Thomas
