>> +typedef struct MemoryDeviceClass {
>> + InterfaceClass parent_class;
>> +
>> + uint64_t (*get_addr)(MemoryDeviceState *md);
>> + uint64_t (*get_plugged_size)(MemoryDeviceState *md, Error **errp);
>> + uint64_t (*get_region_size)(MemoryDeviceState *md, Error **errp);
>
> Just not sure if we need second argument 'Error **errp'? Or all functions
> declarations should have this?
We need them right now due to the existing implementation of PCDIMM. I
don't think we will ever hit such a case (not if anything else is
seriously wrong). If nobody has a problem with it, I'll drop these two
parameters and directly use &error_abort internally (PCDIMM).
Adding Error **errp to functions where we don't expect to be errors
doesn't feel right.
Thanks for pointing this out!
--
Thanks,
David / dhildenb
