On Wed, Apr 18, 2018 at 02:29:47PM +0100, Peter Maydell wrote:
> On 18 April 2018 at 13:47, Daniel P. Berrangé <berra...@redhat.com> wrote:
> > On Wed, Apr 18, 2018 at 02:38:37PM +0200, Olaf Hering wrote:
> >> Since usage of g_realloc_n was introduced, glib-2.22 can not be used
> >> anymore.
> >> Fixes commit 418026ca43 ("util: Introduce vfio helpers")
> >
> > Normally we expect ./include/glib-compat.h to be changed in this scenario
> > to add compat for the missing symbol.
> >
> > IIRC, one of Peters desired build targets required 2.22, but I guess we
> > missed this bug because that platform would not enable vfio functionality ?
>
> Yes, my OSX build system is on glib 2.22. It's using 'fink' for 3rd
> party library installations, and they somehow seem to have got stuck
> on 2.22. Looking at the website the project seems to have basically
> stagnated, and I guess I need to move to homebrew at some point
> (likely after we get 2.12 out the door). But for the moment this
> patch would break my pullrequest testing builds.
Yeah that sounds reasonable as it would also align your build env with
what we are testing via travis too.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
