On 2018年03月27日 19:34, Dr. David Alan Gilbert (git) wrote:
From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
Hi Ed, Jason,
This set of patches change the e1000 migration code to make
it easier to keep with compatibility with older versions in backwards
migration; but I do need some advice whether I need to do more as well.
I think the first and second patch are fairly uncontrovercial and I
would like them for 2.12, since it'll make any future changes easier.
The third one changes the default behaviour, so again I'd prefer it but
lets see what you think.
The patches looks good to me. So for the changes of default behavior,
did you mean we can make the migration to older versions work?
My question however, without knowing the internals of the e1000, is
whether when ommitting the subsection, should the code in 2.12 be
changing the data it sends back in the main section of data?
I'm not sure I get the meaning here. But it looks to me turning it off
for old machine types makes sense, otherwise, management need to set it
explicitly.
Thanks
Dave
Dr. David Alan Gilbert (3):
e1000: Convert v3 fields to subsection
e1000: wire new subsection to property
e1000: Old machine types, turn new subsection off
hw/net/e1000.c | 46 ++++++++++++++++++++++++++++++++++------------
include/hw/compat.h | 4 ++++
2 files changed, 38 insertions(+), 12 deletions(-)
