On 03/26/2018 03:38 AM, Laurent Vivier wrote:
end:
+ if (err) {
+ error_propagate(errp, err);
+ }
"if (err)" is not necessary here. See
scripts/coccinelle/error_propagate_null.cocci.
+ parse_NumaOptions(ms, object, &err);
+
+end:
qapi_free_NumaOptions(object);
if (err) {
error_report_err(err);
We can fix this one too while at it.
Hmm - this is the same script mentioned here:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06293.html
Except that patch didn't pick up this file. Why is Coccinelle not
seeing this?
The script only catch error_propagate(), not error_report_err(). And
error_report_err() doesn't check if err is NULL.
Aha - chalk it up to reviewing late in the day; I saw an 'if (err)' but
didn't pay close attention to what was being guarded in the two
different conditionals.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
