On Thu, Mar 22, 2018 at 10:23 AM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 22 March 2018 at 17:19, Max Filippov <jcmvb...@gmail.com> wrote: >> Ok, I can add a fixup that changes #include <xtensa-isa.h> to #include >> "xtensa-isa.h". >> Adding #include "qemu/osdep.h" there seems pointless to me. > > Every top level .c file must start with including osdep.h. > Other headers that it might include rely on that. > It looks like these files aren't actually top level .c files, > but are only compiled by being #included from some other file. > Our convention for that kind of thing is to give the file > a .inc.c extension. If you follow that then clean-includes > will skip the file rather than trying to apply the requirements > for a top level .c file to it.
Ok, thanks. Will do that too. -- Thanks. -- Max
