On Thu, Mar 22, 2018 at 9:58 AM, Laurent Vivier <lviv...@redhat.com> wrote: > On 22/03/2018 17:51, Max Filippov wrote: >> On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier <lviv...@redhat.com> wrote: >>> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci >>> >>> Signed-off-by: Laurent Vivier <lviv...@redhat.com> >>> --- >>> target/xtensa/core-dc232b/xtensa-modules.c | 56 >>> ++++++---------------- >>> target/xtensa/core-dc233c/xtensa-modules.c | 56 >>> ++++++---------------- >>> target/xtensa/core-de212/xtensa-modules.c | 48 +++++-------------- >>> target/xtensa/core-fsf/xtensa-modules.c | 32 ++++--------- >>> .../xtensa/core-sample_controller/xtensa-modules.c | 24 +++------- >> >> These files were autogenerated, fixing them doesn't make much sense. > > Good to know. They have been already updated by a couple of patches: > > 8f0a3716e4 Clean up includes > d8e39b7062 Use #include "..." for our own headers, <...> for others > > Perhaps import_core.sh can be updated?
Ok, I can add a fixup that changes #include <xtensa-isa.h> to #include "xtensa-isa.h". Adding #include "qemu/osdep.h" there seems pointless to me. -- Thanks. -- Max
