Hi Zihan Yang, On 03/07/2018 01:55 PM, Zihan Yang wrote: > Hi all, this is a bitesized patch from me a while ago, it seems a little > old but I wonder if there is any opinion about it? Is it still valid?
For a single TYPE use, I'm not sure use a specific header is useful (patch #1). The 2nd patch looks valid to me but I'm not a QOM link expert. > > Thanks. > > 2018-02-04 15:28 GMT+08:00 Zihan Yang <whois.zihan.y...@gmail.com>: > >> The ps2_mouse property of vmmouse is still pointer type which >> is defined by DEFINE_PROP_PTR. But qdev pointer property should >> be avoided according to qdev-properties.h. Convert it to >> QOM link relationship. >> >> It involves two patches because it requires the TYPE_I8042 >> macro which is defined in another file. The first patch put >> this macro into a single header file so that the macro can >> be used elsewhere. The second patch does the actual work. >> >> Zihan Yang (2): >> hw/input/pckdb: put TYPE_I8042 into a single header file >> vmmouse: change qdev pointer property to qom link >> >> hw/i386/pc.c | 2 +- >> hw/i386/vmmouse.c | 19 ++++++++++++------- >> hw/input/pckbd.c | 2 +- >> hw/input/pckbd.h | 6 ++++++ >> 4 files changed, 20 insertions(+), 9 deletions(-) >> create mode 100644 hw/input/pckbd.h >> >> -- >> 2.7.4 >> >>
