On Mon, 5 Mar 2018 13:29:15 +0100
Igor Mammedov <imamm...@redhat.com> wrote:
> On Thu, 15 Feb 2018 01:28:38 -0300
> Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
>
> > It ease code review, unit is explicit.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> > ---
> [...]
>
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index deb440f286..9ccc6192b5 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -2320,8 +2320,8 @@ build_tpm2(GArray *table_data, BIOSLinker *linker,
> > GArray *tcpalog)
> > (void *)tpm2_ptr, "TPM2", sizeof(*tpm2_ptr), 4, NULL,
> > NULL);
> > }
> >
> > -#define HOLE_640K_START (640 * 1024)
> > -#define HOLE_640K_END (1024 * 1024)
> > +#define HOLE_640K_START (640 * K_BYTE)
> > +#define HOLE_640K_END (1024 * K_BYTE)
> nit:
> could be 1 * M_BYTE
>
> [...]
>
> Reviewed-by: Igor Mammedov <imamm...@redhat.com>
taking it back
While building it, I get:
In file included from qemu/hw/acpi/ich9.c:38:0:
qemu/include/hw/i386/ich9.h:25:28: error: ‘K_BYTE’ undeclared here (not in a
function)
#define ICH9_CC_SIZE (16 * K_BYTE) /* Chipset configuration registers */
^
qemu/include/hw/i386/ich9.h:56:25: note: in expansion of macro ‘ICH9_CC_SIZE’
uint8_t chip_config[ICH9_CC_SIZE];
^
make: *** [hw/acpi/ich9.o] Error 1
