On Thu, 15 Feb 2018 01:28:38 -0300 Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
> It ease code review, unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- [...] > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index deb440f286..9ccc6192b5 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -2320,8 +2320,8 @@ build_tpm2(GArray *table_data, BIOSLinker *linker, > GArray *tcpalog) > (void *)tpm2_ptr, "TPM2", sizeof(*tpm2_ptr), 4, NULL, NULL); > } > > -#define HOLE_640K_START (640 * 1024) > -#define HOLE_640K_END (1024 * 1024) > +#define HOLE_640K_START (640 * K_BYTE) > +#define HOLE_640K_END (1024 * K_BYTE) nit: could be 1 * M_BYTE [...] Reviewed-by: Igor Mammedov <imamm...@redhat.com>