Hi,
Am Freitag, den 16.02.2018, 16:23 -0300 schrieb Philippe Mathieu-Daudé:
> diff --git a/slirp/slirp.c b/slirp/slirp.c
> > index 1cb6b07004..4f29753444 100644
> > --- a/slirp/slirp.c
> > +++ b/slirp/slirp.c
> > @@ -286,7 +286,7 @@ Slirp *slirp_init(int restricted, bool
> > in_enabled, struct in_addr vnetwork,
> > const char *tftp_path, const char *bootfile,
> > struct in_addr vdhcp_start, struct in_addr
> > vnameserver,
> > struct in6_addr vnameserver6, const char
> > **vdnssearch,
> > - void *opaque)
> > + const char *vdomainname, void *opaque)
> > {
> > Slirp *slirp = g_malloc0(sizeof(Slirp));
> >
> > @@ -317,6 +317,7 @@ Slirp *slirp_init(int restricted, bool
> > in_enabled, struct in_addr vnetwork,
> > }
> > slirp->tftp_prefix = g_strdup(tftp_path);
> > slirp->bootp_filename = g_strdup(bootfile);
>
> I'd use this check:
>
> if (vdomainname) {
> if (!*vdomainname) {
> error_report("'domainname' parameter cannot be empty");
> exit(EXIT_FAILURE);
> }I implemented that check in patch v3. In patch v4 I moved the check logic into net_slirp_init() in net/slirp.c where all the other checks live. -- Benjamin Drung System Developer Debian & Ubuntu Developer ProfitBricks GmbH Greifswalder Str. 207 D - 10405 Berlin Email: benjamin.dr...@profitbricks.com URL: https://www.profitbricks.de Sitz der Gesellschaft: Berlin Registergericht: Amtsgericht Charlottenburg, HRB 125506 B Geschäftsführer: Achim Weiss, Matthias Steinberg
signature.asc
Description: This is a digitally signed message part
