On 15 February 2018 at 22:05, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > Since v3: > - use assert() in sd_state_name() and sd_response_name() (Alistair review) > - added sdmmc-internal.h & sdmmc-common.c to reuse helpers with hw/sd/core.c > > Since v2: > - split again in 2... this part is cleanup/tracing > - add more tracepoints > - move some code reusable by sdbus in sdmmc-internal.h > > Since v1: > - rewrote mostly all patches to keep it simpler. > > $ git backport-diff > 001/11:[----] [--] 'sdcard: reorder SDState struct members' > 002/11:[0003] [FC] 'sdcard: replace DPRINTF() by trace events' > 003/11:[0001] [FC] 'sdcard: add a trace event for command responses' > 004/11:[0007] [FC] 'sdcard: replace fprintf() by qemu_hexdump()' > 005/11:[----] [--] 'sdcard: add more trace events' > 006/11:[----] [--] 'sdcard: do not trace CMD55 when expecting ACMD' > 007/11:[0014] [FC] 'sdcard: define SDMMC_CMD_MAX instead of using the magic > '64'' > 008/11:[0020] [FC] 'sdcard: display command name when tracing CMD/ACMD' > 009/11:[----] [--] 'sdcard: display protocol used when tracing' > 010/11:[----] [-C] 'sdcard: use G_BYTE from cutils' > 011/11:[----] [-C] 'sdcard: use the registerfields API to access the OCR > register'
Hi. I've applied patches 1-5, 7, 10 and 11 to target-arm.next. The rest I've left you review comments for. -- PMM
