On 06/02/2018 21:30, Roman Kagan wrote:
> +/*
> + * Set given event flag for a given sint on a given vcpu, and signal the 
> sint.
> + */
> +int hyperv_set_evt_flag(HvSintRoute *sint_route, unsigned evtno)

Any reason (e.g. something from the spec) not to spell "event" and
"eventno" in full?

Thanks,

Paolo


> +{
> +    int ret;
> +    SynICState *synic = sint_route->synic;
> +    unsigned long *flags, set_mask;
> +    unsigned set_idx;
> +
> +    if (evtno > HV_EVENT_FLAGS_COUNT) {
> +        return -EINVAL;
> +    }
> +    if (!synic->enabled || !synic->evt_page_addr) {


Reply via email to