On 02/04/2018 10:22 PM, Michael Clark wrote:
> Privileged control and status register helpers and page fault handling.
>
> Signed-off-by: Michael Clark <m...@sifive.com>
> ---
> target/riscv/helper.c | 464 ++++++++++++++++++++++++++++++++++
> target/riscv/helper.h | 78 ++++++
> target/riscv/op_helper.c | 644
> +++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 1186 insertions(+)
> create mode 100644 target/riscv/helper.c
> create mode 100644 target/riscv/helper.h
> create mode 100644 target/riscv/op_helper.c
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
> +bool riscv_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
> +{
> +#if !defined(CONFIG_USER_ONLY)
> + if (interrupt_request & CPU_INTERRUPT_HARD) {
> + RISCVCPU *cpu = RISCV_CPU(cs);
> + CPURISCVState *env = &cpu->env;
> + int interruptno = riscv_cpu_hw_interrupts_pending(env);
> + if (interruptno + 1) {
Perhaps clearer as (interrupno >= 0) or (interruptno != -1).
But it's not actively wrong, so tidy at your convenience.
r~
