Fam Zheng <f...@redhat.com> writes: > On Wed, Jan 31, 2018 at 11:48 PM, Thomas Huth <th...@redhat.com> wrote: >> On 31.01.2018 15:48, Markus Armbruster wrote: >>> Clean up includes so that osdep.h is included first and headers >>> which it implies are not included manually. >>> >>> This commit was created with scripts/clean-includes, with the change >>> to target/s390x/gen-features.c manually reverted, and blank lines >>> around deletions collapsed. >> >> Reviewed-by: Thomas Huth <th...@redhat.com> >> >> I wonder whether it would make sense to add a check based on >> scripts/clean-includes to patchew already, so that these includes do not >> sneak in so easily again...? > > (Having not looked at the series), are we clean with this series > applied? If so it makes a good point to do so.
It isn't, but I guess it could be made clean with a bit of work both on sources and the script.