Eric Blake <ebl...@redhat.com> writes: > On 01/31/2018 08:48 AM, Markus Armbruster wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes, with the change >> to target/s390x/gen-features.c manually reverted, and blank lines >> around deletions collapsed. > > Is it worth tweaking scripts/clean-includes to add gen-features.c to the > whitelist of special cases (alongside *.inc.c, perhaps)?
Probably, but I'm in a bit of a time squeeze right now. A naming convention for .c files that only compile when included into something else would make sense. Hmm, like *gasp* .h? Offenders include crypto/cipher-*.c. "git-grep '#include.*\.c'" coughs up more candidates. >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- > > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks!
