Changes v11->v12:
- Rebase.
- Drop the already queued commit (qemu.py: remove unused import)
- Fix code filling the _monitor_address when it's None.
- Drop the redundant commit checking whether VM was running on launch()
- Improve the exception message when launch() is called twice with no
shutdown() in between.
Changes v10->v11:
- Fix messed indentation.
- Rename self._qemu_log_fd to self._qemu_log_file.
- Patch changelog in reverse order.
Changes v9->v10:
- Keep method _remove_if_exists().
Changes v8->v9:
- Some commits were already merged. Rebased the remaining ones.
- New commit to remove unused import.
- VM files control logic changed to use a temporary directory.
- Better naming for variable controlling the need of a shutdown before
next launch.
Changes v7->v8:
- Rebased.
- Reorder commits to avoid break->fix sequence.
- Split commits "use poll() instead of 'returncode'" and "refactor
launch()".
- Don't ignore errors in _load_io_log(). Instead, check if we created
the file before reading it.
- Use LOG.warn() instead of LOG.debug() for the negative exit code
message.
- Fix the exception name called in commits "launch vm only if it's not
running" and "don't launch again before shutdown()".
- Minor style fixes.
Changes v6->v7:
- Split commits in self-contained/atomic changes.
- Addressed the comments from previous version, basically improving the
logging messages and the control over created files. See individual
commit messages for details.
Changes v5->v6:
- Remove the commit to rename self._args.
- Fix is_running() return before first call to maunch().
- Use python logging system.
- Include the full command line on negative exit code error message.
- Use os.path.null instead of /dev/null.
- Improve the control over the created/deleted files.
Changes v4->v5:
- Break the cleanup commit into logical changes and include in the
commit messages the rationale for making them.
Changes v3->v4:
- Squash the 2 first commits since they are co-dependant.
- Cleanup launch() and shutdown().
- Reorder the commits, putting the rename of self._args first.
- Rebased.
Changes v2->v3:
- Fix typo in patch 3 ("qemu.py: make 'args' public") commit message.
Changes v1->v2:
- Style fixes to make checkpatch.pl happy.
- Rebased.
*** SUBJECT HERE ***
*** BLURB HERE ***
Amador Pahim (6):
qemu.py: better control of created files
qemu.py: refactor launch()
qemu.py: always cleanup on shutdown()
qemu.py: use poll() instead of 'returncode'
qemu.py: cleanup redundant calls in launch()
qemu.py: don't launch again before shutdown()
scripts/qemu.py | 93 ++++++++++++++++++++++++++++++++++++++-------------------
1 file changed, 62 insertions(+), 31 deletions(-)
--
2.14.3
