Am 18.01.2018 um 23:45 hat Eric Blake geschrieben: > On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote: > > v2: > > 01: tweak comment > > add Eric's r-b > > 02: new patch > > 03: rewritten, to move form 'bool force' flag to 'enum mode' parameter > > 04: add Eric's r-b > > 05: improve commit message > > tweak comment > > 06: rebase on 03 changes > > make PEP8 happy > > some other tweaks > > I've left nbd_port variable hard-set to 10900. I think all such things > > should be fixed together, and it is simple to change in future > > nbd_port = '10900' > > to > > nbd_port = iotests.get_free_port() > > if needed. > > > > [Unfortunately, qmp query-nbd-server is not finished yet, coming soon, > > but may be after my vocation on the next week] > > Enjoy your time off. I think the series is nearly ready to go; I had > some tweaks that I suggested, and will probably replace your 2/6 with my > counterproposal, but I don't mind doing that cleanup if you don't have > time to respin. I'll give it a few more days in case anyone else has > comments, then add it to my NBD queue.
I haven't reviewed the patches in detail, but the API changes look good to me. Kevin
signature.asc
Description: PGP signature
