19.01.2018 00:08, Eric Blake wrote:
On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote:
Support name parameter for HMP too.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
---
hmp.c | 3 ++-
hmp-commands.hx | 9 +++++----
2 files changed, 7 insertions(+), 5 deletions(-)
+++ b/hmp-commands.hx
@@ -1553,8 +1553,8 @@ ETEXI
{
.name = "nbd_server_add",
- .args_type = "writable:-w,device:B",
- .params = "nbd_server_add [-w] device",
+ .args_type = "name:-n,writable:-w,device:B",
+ .params = "nbd_server_add [-n] [-w] device",
Doesn't quite look like my proposal:
https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg01639.html
- .args_type = "writable:-w,device:B",
- .params = "nbd_server_add [-w] device",
+ .args_type = "writable:-w,device:B,name:s?",
+ .params = "nbd_server_add [-w] device [name]",
In fact, using -n is not quite right, because that's just a boolean flag
rather than a string.
Strange, I don't have your letter. Let's use yours, of course.
--
Best regards,
Vladimir
