On 17.01.2018 22:37, Christian Borntraeger wrote:
>
>
> On 01/17/2018 10:13 PM, David Hildenbrand wrote:
>> On 17.01.2018 20:37, Christian Borntraeger wrote:
>>> stfle.81 (ppa15) is a transparent facility that can be passed to the
>>> guest without the need to implement hypervisor support. As this feature
>>> can be provided by firmware we add it to all full models.
>>>
>>> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
>>> ---
>>> target/s390x/cpu_features.c | 1 +
>>> target/s390x/cpu_features_def.h | 1 +
>>> target/s390x/gen-features.c | 1 +
>>> 3 files changed, 3 insertions(+)
>>>
>>> diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c
>>> index 5d1c210..1550ab0 100644
>>> --- a/target/s390x/cpu_features.c
>>> +++ b/target/s390x/cpu_features.c
>>> @@ -89,6 +89,7 @@ static const S390FeatDef s390_features[] = {
>>> FEAT_INIT("msa4-base", S390_FEAT_TYPE_STFL, 77,
>>> "Message-security-assist-extension-4 facility (excluding subfunctions)"),
>>> FEAT_INIT("edat2", S390_FEAT_TYPE_STFL, 78, "Enhanced-DAT facility 2"),
>>> FEAT_INIT("dfppc", S390_FEAT_TYPE_STFL, 80, "Decimal-floating-point
>>> packed-conversion facility"),
>>> + FEAT_INIT("ppa15", S390_FEAT_TYPE_STFL, 81, "PPA15 is installed"),
>>> FEAT_INIT("bpb", S390_FEAT_TYPE_STFL, 82, "Branch Prediction
>>> Blocking"),
>>> FEAT_INIT("vx", S390_FEAT_TYPE_STFL, 129, "Vector facility"),
>>> FEAT_INIT("iep", S390_FEAT_TYPE_STFL, 130,
>>> "Instruction-execution-protection facility"),
>>> diff --git a/target/s390x/cpu_features_def.h
>>> b/target/s390x/cpu_features_def.h
>>> index 4487cfd..4d93087 100644
>>> --- a/target/s390x/cpu_features_def.h
>>> +++ b/target/s390x/cpu_features_def.h
>>> @@ -80,6 +80,7 @@ typedef enum {
>>> S390_FEAT_MSA_EXT_4,
>>> S390_FEAT_EDAT_2,
>>> S390_FEAT_DFP_PACKED_CONVERSION,
>>> + S390_FEAT_PPA15,
>>> S390_FEAT_BPB,
>>> S390_FEAT_VECTOR,
>>> S390_FEAT_INSTRUCTION_EXEC_PROT,
>>> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
>>> index 95ee870..50bd3f4 100644
>>> --- a/target/s390x/gen-features.c
>>> +++ b/target/s390x/gen-features.c
>>> @@ -357,6 +357,7 @@ static uint16_t full_GEN7_GA1[] = {
>>> S390_FEAT_SIE_GPERE,
>>> S390_FEAT_SIE_IB,
>>> S390_FEAT_SIE_CEI,
>>> + S390_FEAT_PPA15,
>>> S390_FEAT_BPB,
>>
>
>> Is the order in this list still correct?
>
> Is the order in this array important as well? It seems to work fine. At least
> PPA15 is correctly
> ordered vs BPB.
>
Purely style. (when introducing, I tried to keep features in the same
order as defined in target/s390x/cpu_features_def.h )
So feel free to keep the order (or I'll clean this up again one day).
Reviewed-by: David Hildenbrand <da...@redhat.com>
--
Thanks,
David / dhildenb
