On 12/01/2018 13:07, Pavel Dovgalyuk wrote: > > >> -----Original Message----- >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> Sent: Friday, January 12, 2018 12:33 PM >> To: Pavel Dovgalyuk; qemu-devel@nongnu.org >> Cc: kw...@redhat.com; peter.mayd...@linaro.org; m...@redhat.com; >> jasow...@redhat.com; >> quint...@redhat.com; zuban...@gmail.com; maria.klimushenk...@ispras.ru; >> dovga...@ispras.ru; >> kra...@redhat.com; boost.li...@gmail.com; alex.ben...@linaro.org >> Subject: Re: [Qemu-devel] [RFC PATCH v3 00/30] replay additions >> >> On 11/01/2018 13:56, Paolo Bonzini wrote: >>> On 11/01/2018 09:24, Pavel Dovgalyuk wrote: >>>> Accidentally sent draft version of patches to the mailing list. >>>> Please consider this one as the correct one. >>>> >>>> This set of patches includex fixes from Alex Bennée for fixing >>>> BQL and replay locks after inventing the MTTCG. It also includes some >>>> additional replay patches that makes this set of fixes working. >>>> It is also fixes some vmstate creation (and loading) issues >>>> in record/replay modes: >>>> - VM start/stop fixes in replay mode >>>> - overlay creation for blkreplay filter >>>> - fixes for vmstate save/load in record/replay mode >>>> - fixes for host clock vmstate >>>> - fixes for icount timers vmstate >>>> >>>> There is also a set of helper scripts written by Alex Bennée >>>> for debugging the record/replay code. >>> >>> For now, I'm applying patches 13, 24-26 and 28. >> >> Which don't compile on Windows. > > I can't build current version of qemu on Windows. > For the first time this happened when capstone was included into the build.
I've fixed it now. But please do not submit patches that obviously need a Windows version without testing them (on Linux you can use "make docker-test-mingw@fedora" for example if you have a Docker setup). Paolo