On 01/10/2018 06:21 PM, Michael Clark wrote: > +static inline void cpu_get_tb_cpu_state(CPURISCVState *env, target_ulong *pc, > + target_ulong *cs_base, uint32_t > *flags) > +{ > + *pc = env->pc; > + *cs_base = 0; > + *flags = 0; /* necessary to avoid compiler warning */ > +}
Actually, at minimum you have to put enough into flags to differentiate machine vs supervisor vs user mode. Otherwise you can wind up running a previously translated block with the wrong permissions. The patch I saw from Stefan O'Rear would do nicely. r~