Since v3: - since the series was getting too big and first part reviewed, split in 2. - addressed Fam's review from "refactor the common sysbus/pci qdev" - improved commit descriptions - restored useful s->fifo_buffer = NULL - added Alistair R-b
Patches still missing review: 4, 5, 7, 12. Since v2: - more detailed 'capabilities', all boards converted to use these properties - since all qtests pass, removed the previous 'capareg' property - added Stefan/Alistair R-b - corrected 'access' LED behavior (Alistair's review) - more uses of the registerfields API - remove some dead code - cosmetix: - added more comments - renamed a pair of registers - reordered few struct members Note, the bcm2835 seems to have 1KB minimum blocksize, however the current model is implemented with 512B. I didn't change the current value. Since v1: - addressed Alistair Francis review comments, added some R-b - only move register defines to "sd-internal.h" - fixed deposit64() arguments - dropped unuseful s->fifo_buffer = NULL - use a qemu_irq for the LED, restrict the logging to ON/OFF - fixed a trace format string error - included Andrey Smirnov ACMD12ERRSTS write patch - dropped few unuseful patches, and separate the Python polemical ones for later >From the "SDHCI housekeeping" series: - 1: we restrict part of "sd/sd.h" into local "sd-internal.h", - 2,3: we somehow beautiful the code, no logical changes, - 4-7: we refactor the common sysbus/pci qdev code, - 8-10: we add plenty of trace events which will result useful later, - 11: we finally expose a "dma-memory" property. >From the "SDHCI: add a qtest and fix few issues" series: - 12,13: fix registers - 14,15: boards can specify which SDHCI Spec to use (v2 and v3 so far) - 15-20: HCI qtest Regards, Phil. $ git backport-diff [----] : patches are identical [####] : number of functional differences between upstream/downstream patch The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively 001/17:[----] [--] 'sdhci: clean up includes' 002/17:[----] [--] 'sdhci: sort registers comments' 003/17:[----] [--] 'sdhci: remove dead code' 004/17:[----] [--] 'sdhci: refactor same sysbus/pci properties into a common one' 005/17:[----] [--] 'sdhci: refactor common sysbus/pci class_init() into sdhci_class_init()' 006/17:[0021] [FC] 'sdhci: refactor common sysbus/pci realize() into sdhci_realizefn()' 007/17:[0008] [FC] 'sdhci: refactor common sysbus/pci unrealize() into sdhci_unrealizefn()' 008/17:[----] [--] 'sdhci: use qemu_log_mask(UNIMP) instead of fprintf()' 009/17:[----] [--] 'sdhci: convert the DPRINT() calls into trace events' 010/17:[----] [--] 'sdhci: add a GPIO for the 'access control' LED' 011/17:[----] [--] 'sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h"' 012/17:[----] [--] 'sdhci: use FIELD_DP32() macro for the WRITE_PROTECT flag' 013/17:[----] [--] 'sdhci: rename the SDHC_CAPAB register' 014/17:[----] [--] 'sdhci: fix CAPAB/MAXCURR registers, both are 64bit and read-only' 015/17:[----] [--] 'sdhci: Implement write method of ACMD12ERRSTS register' 016/17:[----] [--] 'sdhci: use deposit64() on admasysaddr' 017/17:[----] [-C] 'sdhci: add a "dma-memory" property' Andrey Smirnov (1): sdhci: Implement write method of ACMD12ERRSTS register Philippe Mathieu-Daudé (16): sdhci: clean up includes sdhci: sort registers comments sdhci: remove dead code sdhci: refactor same sysbus/pci properties into a common one sdhci: refactor common sysbus/pci class_init() into sdhci_class_init() sdhci: refactor common sysbus/pci realize() into sdhci_realizefn() sdhci: refactor common sysbus/pci unrealize() into sdhci_unrealizefn() sdhci: use qemu_log_mask(UNIMP) instead of fprintf() sdhci: convert the DPRINT() calls into trace events sdhci: add a GPIO for the 'access control' LED sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h" sdhci: use FIELD_DP32() macro for the WRITE_PROTECT flag sdhci: rename the SDHC_CAPAB register sdhci: fix CAPAB/MAXCURR registers, both are 64bit and read-only sdhci: use deposit64() on admasysaddr sdhci: add a "dma-memory" property include/hw/sd/sdhci.h | 38 +++++-- hw/sd/sdhci-internal.h | 11 +- hw/sd/sdhci.c | 291 ++++++++++++++++++++++++++++--------------------- hw/sd/trace-events | 15 +++ 4 files changed, 216 insertions(+), 139 deletions(-) -- 2.15.1
