* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Dec 14, 2017 at 04:27:31PM +0100, Igor Mammedov wrote: > > Also it seems that we have a race in current code where > > region_del() unrefs memory region first and then by the > > commit time memory region could be gone since old flatview > > is unreffed before commit callback is called, but guest still > > uses old memory map until vhost_set_mem_table() is complete. > > We probably should unref deleted(old) sections after > > guest gets new memmap. > > Care trying to post a patch for stable? Might be a good idea > to merge before this rework, for the sake of downstreams.
I think the 1st patch of my v5 might be suitable for that; please have a look. Dave > > > > > } > > > > > > static int vhost_virtqueue_set_addr(struct vhost_dev *dev, -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
