On 12/14/2017 12:21 PM, Paolo Bonzini wrote: > On 14/12/2017 17:06, John Snow wrote: >>> >>> And another question. After this series there is exactly one >>> block_job_sleep_ns call (in block/mirror.c). Perhaps instead of >>> block_job_throttle, you should refine block_job_sleep_ns? >>> >> Yeah, maybe? "A rose by any other name," though -- I think I might be >> coming for the block/mirror call next because I have one more downstream >> BZ that references this as a job that can cause the warning print. >> >> So maybe we'll just have throttle calls instead of sleep calls from here >> on out. > > Ok, shall we wait for v2 where you look at that BZ as well? > > Thanks, > > Paolo >
Sure -- if the only feedback you have on this series is primarily style and "maybe there are some more wins" I can spin a v2 to try to broaden the scope if it looks good so far. --js
